RFR: 8316113: Infinite permission checking loop in java/net/spi/InetAddressResolverProvider/RuntimePermissionTest [v3]

Aleksei Efimov aefimov at openjdk.org
Tue Sep 12 14:48:44 UTC 2023


On Tue, 12 Sep 2023 13:22:20 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> See the bug for stack traces. This causes a very intermittent test failure: when we call for `LOGGER.info` from our custom security manager, it goes into formatter, which loads locale data, which causes class load, which goes back to this custom security manager, starting the loop again. 
>> 
>> I think we get lucky most of the time to load the relevant classes outside this path. But sometimes, we don't get as lucky.
>> 
>> Additional testing:
>>  - [x] 500x iterations of [JDK-8315640](https://bugs.openjdk.org/browse/JDK-8315640) reproducer
>
> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Replace logger with System.err

Thanks for making the replacement. The changes look good to me.

-------------

Marked as reviewed by aefimov (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15681#pullrequestreview-1622437910


More information about the net-dev mailing list