RFR: 8309118: HttpClient: Add more tests for 100 ExpectContinue with HTTP/2

[Conor Cleary]

On Mon, 11 Sep 2023 15:09:22 GMT, Conor Cleary <ccleary at openjdk.org> wrote:

> ### **Issue Description**
> There is missing test coverage for the implementation of partial/informational responses (status code 1xx in server response headers) for the `HttpClient`, specifically in the `HTTP/2` use case. RFC 9113 - HTTP/2, details the behavior of any client in these situations. Small changes and new test cases are needed to verify compliance with this specification.  This issue primarily concerns how the client reacts to receiving a `RST_STREAM` frame at various stages of a partial/informational response from a server.
> 
> ### **Solution Details**
> Minor changes were made in `src/java.net.http/share/classes/jdk/internal/net/http/Stream.java` to improve the handling client's handling of receiving a `RST_STREAM`. `incoming_reset()` (L574) will now cause the client to ignore a `RST_STREAM` frame if an `END_STREAM` flag has been received _and_ the request body has completed sending. Previously it would be ignored only if an `END_STREAM` flag was seen which caused cancelled partial responses to 'hang' indefinitely should a client be transmitting data in a POST/PUT request. Some changes where also made to the `schedule()` method in Stream (L190) to ensure both the sending of the Request Body and receipt of a RST_STREAM at various stages of an exchange do not cause unexpected behavior.
> 
> Minor changes were made to the `Http2TestServer` implementation to improve the convinience of testing edge cases involving the sending of `HTTP/2` response headers. 
> 
> Concerning the new test cases, I have listed below the specifics of each case and the expected behavior of the client in the given scenario.
> 
> **test/jdk/java/net/httpclient/ExpectContinueTest.java**
> - Client sends a POST request with the `Expect: 100-Continue` header included
>    - Server responds with a `HEADERS` frame including a 100 status code and reads the request body. Server then sends `RST_STREAM` with code `NO_ERROR` or `PROTOCOL_ERROR` set.
>        - Expected/Observed Client Behavior: Client completes exceptionally in both cases.
> - Client sends a POST request with the `Expect: 100-Continue` header included
>    - Server responds with a `HEADERS` frame including a 100 status code and reads the request body. Server then sends Response Headers with status code 200 to complete the response. Server then sends RST_STREAM with code `NO_ERROR` or `PROTOCOL_ERROR` set.
>        - Expected/Observed Client Behavior: Client completes exceptionally in both cases.
> - Client sends a POST request with the `Expect: 10...

At the moment, I don't believe this is safe to commit. I'm seeing a very rare test timeout that could cause issues down the line. Specifically when the client hits the `/resetStreamAfter200NoError` URI, meaning that this failure is probably possible in the following `/resetStreamAfter200Error` case also. I'll be working to address this issue in due course.

I will also, in the same changeset, remove extraneous whitespace as highlighted and make a few stylistic updates (some of the variable names in tests are unnecessarily long, test data has unused parameters etc.)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15664#issuecomment-1719048171