RFR: 8316681: Rewrite URLEncoder.encode to use small reusable buffers [v4]

Daniel Fuchs dfuchs at openjdk.org
Fri Sep 22 09:38:15 UTC 2023


On Fri, 22 Sep 2023 08:19:52 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> FWIW this doesn't change behavior of `encode`, since this is what `String::getBytes(Charset)` does (and is specified to do):
>> ``` 
>>      * <p> This method always replaces malformed-input and unmappable-character
>>      * sequences with this charset's default replacement byte array.
>> 
>> I'd be happy to spell it out in the documentation, just pointing out that it's been long-standing behavior.
>
>> I'd be happy to spell it out in the documentation, just pointing out that it's been long-standing behavior.
> 
> Right, I wasn't suggesting there is behavior change, instead I was pointing out to Daniel that the spec is incomplete and we should clarify it, it would be a separate update/PR and would require a CSR to track the spec update.

@AlanBateman I have logged [JDK-8316734](https://bugs.openjdk.org/browse/JDK-8316734)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15865#discussion_r1334144048


More information about the net-dev mailing list