RFR: 8316580: HttpClient with StructuredTaskScope does not close when a task fails [v3]
Daniel Fuchs
dfuchs at openjdk.org
Tue Sep 26 16:14:13 UTC 2023
On Tue, 26 Sep 2023 09:15:52 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
>>
>> - Rename test, use TestTaskScope
>> - Make the test independent of any preview API, and use regular threads
>> - Improve the fix to make sure dependent actions are all executed
>> - Merge branch 'master' into HttpGetWithCancelledStructuredScope-8316580
>> - Merge branch 'master' into HttpGetWithCancelledStructuredScope-8316580
>> - 8316580
>
> test/jdk/java/net/httpclient/HttpGetInCancelledFuture.java line 97:
>
>> 95: }
>> 96:
>> 97: static final String HOST = "localhost:62057";
>
> Should we have something listening on that port? Some of our tests used to fail after receiving an unexpected connenction, and 62057 is in the ephemeral range.
@djelinski Now done.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15883#discussion_r1337466110
More information about the net-dev
mailing list