RFR: 8316580: HttpClient with StructuredTaskScope does not close when a task fails [v6]

[Daniel Jeliński]

On Thu, 28 Sep 2023 10:05:06 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Hi, 
>> 
>> Please find below a fix for 8316580: HttpClient with StructuredTaskScope does not close when a task fails.
>> 
>> The problem here is a subtle reference release issue: Interrupting the VirtualThread means that the CompletableFuture returned by sendAsync is eligible for GC after having been cancelled, which in turn means that some of the intermediate operations that would have been completed before that CF was completed get eligible for being GC’ed too. One of these intermediate operations is the action that decrements the ref counting. Since the refcount isn’t decremented properly, the client won’t exit. 
>> 
>> Holding onto the CompletableFuture returned to the caller by HttpClient::sendAsync until that CompletableFuture gets completed from upstream fixes the issue.
>
> Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   improved logic in whenCancelled

LGTM. Thanks!

-------------

Marked as reviewed by djelinski (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15883#pullrequestreview-1648380213