RFR: 8317246: Cleanup java.net.URLEncoder and URLDecoder use of file.encoding property

Daniel Fuchs dfuchs at openjdk.org
Thu Sep 28 18:23:26 UTC 2023


On Sat, 19 Aug 2023 09:05:47 GMT, Glavo <duke at openjdk.org> wrote:

> `DEFAULT_ENCODING_NAME ` in `URLEncoder` and `URLDecoder` can be replaced with `Charset.defaultCharset()`, which removes unnecessary static fields and avoid looking up charset when calling `URLDecoder.decode(String)` and `URLEncoder.encode(String)`.
> 
> This PR is trivial, since `Charset.defaultCharset()` is also initialized with `StaticProperty.fileEncoding()`, this causes no change in behavior. 
> 
> Moreover, the javadoc of `URLDecoder.decode(String)` and `URLEncoder.encode(String)` say that they use the default charset, so this change is semantically consistent with the documentation.

This looks reasonable. Have you run tier2?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15353#issuecomment-1739805770


More information about the net-dev mailing list