RFR: 8317295: ResponseSubscribers.SubscriberAdapter should call the finisher function asynchronously [v3]

Daniel Fuchs dfuchs at openjdk.org
Fri Sep 29 11:07:06 UTC 2023


> The finisher function supplied to `BodySubscribers.fromSubscriber` is specified to be called when `onComplete()` is called on the `BodySubscriber`. However, this function contains application code that may involve blocking operations. Though this is technically a user error to block in any function supplied to the HttpClient API, the `ResponseSubscribers.SubscriberAdapter` should protect itself against this by calling the finisher asynchronously, in the fork join pool.

Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision:

  Update @bug

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/15981/files
  - new: https://git.openjdk.org/jdk/pull/15981/files/82addf80..a19c1e68

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=15981&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=15981&range=01-02

  Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/15981.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/15981/head:pull/15981

PR: https://git.openjdk.org/jdk/pull/15981


More information about the net-dev mailing list