RFR: 8329662: Add a test to verify the behaviour of the default HEAD() method on HttpRequest.Builder

Daniel Fuchs dfuchs at openjdk.org
Thu Apr 4 16:34:11 UTC 2024


On Thu, 4 Apr 2024 11:50:32 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Can I please get a review of this test-only change which updates an existing test case to verify the behaviour of `HttpRequest.Builder.HEAD()` method?
> 
> As noted in https://bugs.openjdk.org/browse/JDK-8329662, this test now verifies the default implementation specified for `HttpRequest.Builder.HEAD()`. The existing tests were only verifing the behaviour of the `HEAD()` method implementation in the class of the instance returned from `HttpRequest.newBuilder()`. 
> 
> I have run this test in our CI with these changes and the test continues to pass.

LGTM

-------------

PR Review: https://git.openjdk.org/jdk/pull/18622#pullrequestreview-1980502348


More information about the net-dev mailing list