RFR: 8329745: Update the documentation of ServerSocket and Socket to refer to StandardSocketOptions instead of legacy SocketOptions [v2]

Jaikiran Pai jpai at openjdk.org
Fri Apr 5 12:06:21 UTC 2024


On Fri, 5 Apr 2024 11:29:14 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> src/java.base/share/classes/java/net/ServerSocket.java line 867:
>> 
>>> 865:      * setting of {@link StandardSocketOptions#SO_REUSEADDR SO_REUSEADDR}.
>>> 866:      * <p>
>>> 867:      * The behaviour when {@link StandardSocketOptions#SO_REUSEADDR SO_REUSEADDR} is
>> 
>> I suppose the main question here is whether the description really needs to link to SO_REUSEADDR five times, it seems a bit excessive. In cases like this I tend to just have the first usage link, others do it differently.
>
> Hello Alan, I too typically follow the process of linking once and then using `{@code SO_REUSEADDR}`. I let it stay in this form since it was already that way. I'll go ahead and update it to link only once.

Done - I've updated the PR to remove the repeated links.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18646#discussion_r1553507116


More information about the net-dev mailing list