RFR: 8326568: jdk/test/com/sun/net/httpserver/bugs/B6431193.java should use try-with-resource and try-finally [v3]
Darragh Clarke
dclarke at openjdk.org
Mon Apr 8 15:34:11 UTC 2024
> Currently this test occasionally doesn't cleanup between runs, sometimes not stopping the server or leaving Streams open
>
> Changes:
> - Use try-with-resources to ensure streams close.
> - Use try-finally to make sure the server stops before the test exits.
>
> I ran tiers 1-3 and ran this specific test on repeat and everything seems stable after the changes
Darragh Clarke has updated the pull request incrementally with one additional commit since the last revision:
implementing feedback
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/18514/files
- new: https://git.openjdk.org/jdk/pull/18514/files/1294dbc0..c540dd58
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=18514&range=02
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=18514&range=01-02
Stats: 13 lines in 1 file changed: 4 ins; 4 del; 5 mod
Patch: https://git.openjdk.org/jdk/pull/18514.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/18514/head:pull/18514
PR: https://git.openjdk.org/jdk/pull/18514
More information about the net-dev
mailing list