RFR: 8329745: Update the documentation of ServerSocket and Socket to refer to StandardSocketOptions instead of legacy SocketOptions [v4]

Alan Bateman alanb at openjdk.org
Tue Apr 9 10:24:09 UTC 2024


On Tue, 9 Apr 2024 07:54:19 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

> @jaikiran the only reservation I have is that the new wording makes it look like the default implementation of `ServerSocket` methods is going to call `SocketImpl::getOption(SocketOption<>)` while in fact it still calls `SocketImpl::getOption(SocketOptions)`. 

I think the proposal is okay. It just specifies that set/gets the socket options, it doesn't specify whether it calls the SocketImpl's setOption(int, Object) or setOption(SocketOption, Object) methods.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18646#issuecomment-2044655847


More information about the net-dev mailing list