RFR: 8326568: jdk/test/com/sun/net/httpserver/bugs/B6431193.java should use try-with-resource and try-finally [v3]
Jaikiran Pai
jpai at openjdk.org
Tue Apr 9 13:12:11 UTC 2024
On Mon, 8 Apr 2024 15:34:11 GMT, Darragh Clarke <dclarke at openjdk.org> wrote:
>> Currently this test occasionally doesn't cleanup between runs, sometimes not stopping the server or leaving Streams open
>>
>> Changes:
>> - Use try-with-resources to ensure streams close.
>> - Use try-finally to make sure the server stops before the test exits.
>>
>> I ran tiers 1-3 and ran this specific test on repeat and everything seems stable after the changes
>
> Darragh Clarke has updated the pull request incrementally with one additional commit since the last revision:
>
> implementing feedback
Thank you Darragh for the updates. This now looks good to me.
-------------
Marked as reviewed by jpai (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/18514#pullrequestreview-1988996486
More information about the net-dev
mailing list