RFR: 8315767: InetAddress: constructing objects from BSD literal addresses [v2]
Sergey Chernyshev
schernyshev at openjdk.org
Thu Apr 11 12:58:08 UTC 2024
On Thu, 11 Apr 2024 09:56:56 GMT, Florent Guillaume <duke at openjdk.org> wrote:
>> Sergey Chernyshev has updated the pull request incrementally with one additional commit since the last revision:
>>
>> addressed review comments in Javadoc
>
> test/jdk/java/net/InetAddress/OfLiteralTest.java line 232:
>
>> 230: // with leading 0s treated as octal segment prefixes
>> 231: Arguments.of(InetAddressClass.INET4_ADDRESS_POSIX,
>> 232: "0177.0200401", ipv4_127_1_1_1),
>
> Instead of 127.0.1.1 and 127.1.1.1 I would suggest instead testing 127.0.1.2 and 127.1.2.3 so that endianness is demonstrated (i.e. which of 0x102 vs 0x201 gives that result, similarly for octal).
done
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18493#discussion_r1560979314
More information about the net-dev
mailing list