RFR: 8315767: InetAddress: constructing objects from BSD literal addresses [v5]

Jaikiran Pai jpai at openjdk.org
Wed Apr 17 14:51:43 UTC 2024


On Wed, 17 Apr 2024 14:37:56 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Sergey Chernyshev has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Update src/java.base/share/classes/java/net/Inet4Address.java
>>    
>>    Co-authored-by: Daniel Fuchs <67001856+dfuch at users.noreply.github.com>
>>  - Update src/java.base/share/classes/java/net/Inet4Address.java
>>    
>>    Co-authored-by: Daniel Fuchs <67001856+dfuch at users.noreply.github.com>
>
> src/java.base/share/classes/java/net/Inet4Address.java line 104:
> 
>> 102:  * Purposes</i></a>.
>> 103:  * <p> For methods that return a textual representation as output
>> 104:  * value, the first form, i.e. a dotted-quad string, is used.
> 
> Maybe something like this?
> 
> Suggestion:
> 
>  * <p> For methods that return a textual representation as output
>  * value, the first form, i.e. a dotted-quad string in strict decimal notation, is used.

Yes, I think this makes it clear.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18493#discussion_r1568978096


More information about the net-dev mailing list