RFR: 8330523: Reduce runtime and improve efficiency of KeepAliveTest [v2]

Daniel Fuchs dfuchs at openjdk.org
Thu Apr 18 13:27:01 UTC 2024


On Thu, 18 Apr 2024 12:40:27 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>> The test case sun/net/www/http/HttpClient/KeepAliveTest.java could be more effective.
>> 
>> It tests a matrix of HTTP client settings and server behavior, resulting in 160 individual test scenarios. Each is tested in an own freshly spawned JVM via the `@run main/othervm` directive. The need for new VMs is due to the fact that the behavior of the HTTP client is determined at VM initialization and can not be changed later on. However, for each distinct type of client settings, one VM can be reused. This would lead us from 160 JVM instantiations down to 16 which has a factor 10 influence on test runtime.
>> 
>> E.g. on my developer laptop runtime went down from ~100s to ~10s.
>> 
>> I also made additional cleanups/refactoring in the test.
>
> Christoph Langer has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Small further cleanup

Hi Christoph - thanks for this fix. It looks like a very nice improvement. Please give us some time to test the changes through our CI.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18817#issuecomment-2063862610


More information about the net-dev mailing list