RFR: 6968351: httpserver clashes with delayed TCP ACKs for low Content-Length [v15]

Daniel Jeliński djelinski at openjdk.org
Tue Apr 23 08:32:30 UTC 2024


On Mon, 22 Apr 2024 12:48:57 GMT, robert engels <duke at openjdk.org> wrote:

>> fix bug JDK-B6968351 by avoiding flush after response headers
>
> robert engels has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Revert "flush after exchange returns"
>   
>   This reverts commit 30340e58be8ae08205400079b055460ed9ac2e25.

test/jdk/com/sun/net/httpserver/bugs/TcpNoDelayNotRequired.java line 83:

> 81:         long time = System.currentTimeMillis()-start;
> 82:         System.out.println("time "+time);
> 83:         if(time>5000) throw new IllegalStateException("took too long");

Please drop this line. The timeout will be handled by jtreg, and this line makes the test fail on some of our slower CI machines.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18667#discussion_r1575861044


More information about the net-dev mailing list