RFR: 8330814: Cleanups for KeepAliveCache tests [v2]
Jaikiran Pai
jpai at openjdk.org
Wed Apr 24 06:50:28 UTC 2024
On Tue, 23 Apr 2024 08:39:56 GMT, Christoph Langer <clanger at openjdk.org> wrote:
>> While working in that area I found some potential for cleanup of a few tests.
>>
>> Most notably:
>>
>> B5045306.java:
>> - does not need to run in othervm
>> - the executor service that it uses should be shut down eventually to free resources
>>
>> B8291637.java:
>> - use just one instead of two test VM invocations
>> KeepAliveTimerThread.java:
>> call to grp.destroy() at the end is pointless (API is void & deprecated for removal)
>>
>> Generally:
>> The deprecated URL constructor is used. It can be switched to the handy URIBuilder
>> Some more try with resources here and there
>
> Christoph Langer has updated the pull request incrementally with one additional commit since the last revision:
>
> Update test/jdk/sun/net/www/http/KeepAliveCache/B5045306.java
>
> Co-authored-by: Andrey Turbanov <turbanoff at gmail.com>
test/jdk/sun/net/www/http/KeepAliveCache/B5045306.java line 55:
> 53:
> 54: /* Part 1:
> 55: * The http client makes a connection to a URL who's content contains a lot of
I think it should be "whose"
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18884#discussion_r1577363523
More information about the net-dev
mailing list