RFR: 8330523: Reduce runtime and improve efficiency of KeepAliveTest [v3]

Christoph Langer clanger at openjdk.org
Wed Apr 24 13:27:30 UTC 2024


On Wed, 24 Apr 2024 09:39:46 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:

>> Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>> 
>>  - Simplify the test further
>>  - Merge branch 'master' into JDK-8330523
>>  - Small further cleanup
>>  - JDK-8330523
>
> test/jdk/sun/net/www/http/HttpClient/KeepAliveTest.java line 315:
> 
>> 313:         keepAliveKeyClassconstructor.setAccessible(true);
>> 314: 
>> 315:         Logger logger = Logger.getLogger("sun.net.www.protocol.http.HttpURLConnection");
> 
> the logger was a static field for a reason; we don't want it to be GCed in the middle of the test

correct. Will change it back.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18817#discussion_r1577886527


More information about the net-dev mailing list