RFR: 8331063: Some HttpClient tests don't report leaks
Daniel Fuchs
dfuchs at openjdk.org
Wed Apr 24 18:01:27 UTC 2024
On Wed, 24 Apr 2024 16:21:39 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:
> This patch fixes leak reporting in `ForbiddenHeadTest.java` and `ProxySelectorTest.java`.
>
> The tests were checking for leaks, but the detected problems were not reported to the test harness. Additionally, `ForbiddenHeadTest.java` was holding references to the clients, preventing them from being collected by GC.
>
> The tests continue to pass.
LGTM. Thanks for finding the issue and fixing it.
-------------
Marked as reviewed by dfuchs (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/18938#pullrequestreview-2020579069
More information about the net-dev
mailing list