RFR: 6968351: httpserver clashes with delayed TCP ACKs for low Content-Length [v17]

Jaikiran Pai jpai at openjdk.org
Thu Apr 25 12:23:33 UTC 2024


On Tue, 23 Apr 2024 19:10:48 GMT, robert engels <duke at openjdk.org> wrote:

>> fix bug JDK-B6968351 by avoiding flush after response headers
>
> robert engels has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix broken test cases

test/jdk/com/sun/net/httpserver/bugs/TcpNoDelayNotRequired.java line 84:

> 82:         System.out.println("time "+time);
> 83:         server.stop(0);
> 84:         executor.shutdown();

Please use a try/finally block to stop the `server`. The `try` can start immediately after the `server.start()` call.

Similarly, for the `executor` and the `HttpClient`, you can use a try-with-resource block to close them too.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18667#discussion_r1579374672


More information about the net-dev mailing list