RFR: 6968351: httpserver clashes with delayed TCP ACKs for low Content-Length [v17]

robert engels duke at openjdk.org
Thu Apr 25 12:57:38 UTC 2024


On Thu, 25 Apr 2024 12:39:56 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> robert engels has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix broken test cases
>
> test/jdk/java/net/Authenticator/B4769350.java line 358:
> 
>> 356:         {
>> 357:             exchange.getResponseHeaders().add("Proxy-Authenticate", reply);
>> 358:             exchange.sendResponseHeaders(407, -1);
> 
> Similarly here:
> 
> 
> exchange.sendResponseHeaders(407, -1 /* no response body */);

I think a better solution would be to add a constant to the api class - rather than adding comments everywhere. E.g NO_CONTENT=-1 and UNLIMITED_CONTENT=0 or INDETERMINENT_CONTENT=0, or CHUNKED_CONTENT=0

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18667#discussion_r1579419796


More information about the net-dev mailing list