Withdrawn: 8335181: Incorrect handling of HTTP/2 GOAWAY frames in HttpClient

Jaikiran Pai jpai at openjdk.org
Tue Aug 13 13:30:58 UTC 2024


On Fri, 2 Aug 2024 11:13:42 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Can I please get a review of this change which fixes the issue noted in https://bugs.openjdk.org/browse/JDK-8335181?
> 
> As noted in that issue, the current implementation in the `java.net.http.HttpClient` doesn't correctly handle an incoming GOAWAY frame. The HTTP3 RFC https://www.rfc-editor.org/rfc/rfc9113#name-goaway notes the specifics on what the expectations are when an endpoint receives a GOAWAY frame from the peer.
> 
> Before the changes proposed in this PR, the HttpClient implementation would (incorrectly) shutdown the connection and abort requests when a GOAWAY frame was received. The changes in this PR fixes that by retrying relevant unprocessed requests (if any) and not initiating any new streams on the connection.
> 
> A new test has been introduced to exercise this detail. The test continues to pass along with other existing tests. tier testing as well as a repeated testing (with test-repeat 50) is currently in progress with this change.

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jdk/pull/20442


More information about the net-dev mailing list