RFR: 8336817: DatagramSocket.connect does not specify behavior when already connected [v5]

Daniel Fuchs dfuchs at openjdk.org
Mon Aug 19 12:26:50 UTC 2024


On Mon, 19 Aug 2024 01:48:15 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Can I please get a review of this doc-only change which updates the javadoc on several methods of the `java.net.DatagramSocket` class to match its current implementation?
>> 
>> This addresses https://bugs.openjdk.org/browse/JDK-8336817.
>> 
>> I'll open a CSR once we settle on the proposed text.
>
> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
> 
>   address javadoc on methods of MulticastSocket too

LGTM. One could argue that an I/O error encompasses the fact that the socket is closed, but what you have is fine, since "or the socket is closed" was added everywhere else.

-------------

Marked as reviewed by dfuchs (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20543#pullrequestreview-2245411234


More information about the net-dev mailing list