RFR: 8345074: java.net.InterfaceAddress constructor could be made private [v2]

Eirik Bjørsnøs eirbjo at openjdk.org
Sun Dec 1 05:53:44 UTC 2024


On Sun, 1 Dec 2024 01:32:31 GMT, Chen Liang <liach at openjdk.org> wrote:

> We should word like "this constructor is called via JNI in NetworkInterface.c" so we know what care we need to take when we update this constructor.

Thanks! Yes, simpler to just say where the constructor is called from. It folllows from this that instances are not meant to be created from Java code.

Pointing out that it's private adds little value as it's now obvious from the access modifier.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22467#discussion_r1864746087


More information about the net-dev mailing list