RFR: 8343791: Socket.connect API should document whether the socket will be closed when hostname resolution fails or another error occurs [v26]

[Volkan Yazıcı]

On Fri, 29 Nov 2024 16:34:50 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Volkan Yazıcı has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Improve Javadoc
>>  - Match `UHE` message in `Socket` and `SocketImpl`
>>    
>>    This discrepancy was causing following tests to fail:
>>    
>>    - javax/xml/jaxp/unittest/common/dtd/DOMTest.java
>>    - javax/xml/jaxp/unittest/common/dtd/SAXTest.java
>>    - javax/xml/jaxp/unittest/common/catalog/SAXTest.java
>>    - javax/xml/jaxp/unittest/common/catalog/DOMTest.java
>
> test/jdk/java/net/Socket/ConnectFailTest.java line 48:
> 
>> 46:  * @bug 8343791
>> 47:  * @summary verifies that `connect()` failures throw expected exception and leave both `Socket` and the underlying
>> 48:  *          `SocketImpl` at the same expected state
> 
> I think you can drop the mention of the underlying SocketImpl from the summary as the test doesn't do that.

Dropped.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22160#discussion_r1865399206