Integrated: 8235786: Javadoc for com/sun/net/httpserver/HttpExchange.java#setAttribute is unclear

Jaikiran Pai jpai at openjdk.org
Tue Dec 3 02:38:44 UTC 2024


On Fri, 29 Nov 2024 09:13:31 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Can I please get a review of this doc-only change which proposes to clarify the behaviour of `com.sun.net.httpserver.HttpExchange.setAttribute()` and `com.sun.net.httpserver.HttpExchange.getAttribute()` methods?
> 
> As noted in https://bugs.openjdk.org/browse/JDK-8235786, it's not clear from the javadoc of these methods that the attributes that are set or retrieved through the exchange are actually those that belong to the entire `com.sun.net.httpserver.HttpContext` and thus are shared by all exchanges.
> 
> The commit in this PR specifies this behaviour to match the current implementation. I'll file a CSR once we settle on the text.

This pull request has now been integrated.

Changeset: 40ae4699
Author:    Jaikiran Pai <jpai at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/40ae4699622cca72830acd146b7b5c4efd5a43ec
Stats:     131 lines in 2 files changed: 108 ins; 5 del; 18 mod

8235786: Javadoc for com/sun/net/httpserver/HttpExchange.java#setAttribute is unclear

Reviewed-by: dfuchs, michaelm

-------------

PR: https://git.openjdk.org/jdk/pull/22454


More information about the net-dev mailing list