RFR: 8345375: Improve debuggability of test/jdk/java/net/Socket/CloseAvailable.java

Daniel Fuchs dfuchs at openjdk.org
Tue Dec 3 14:34:39 UTC 2024


On Tue, 3 Dec 2024 10:50:37 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Can I please get a review of this test-only change which should improve the debuggability of the `test/jdk/java/net/Socket/CloseAvailable.java` test?
> 
> The test has been intermittently failing in our CI as noted in https://bugs.openjdk.org/browse/JDK-8269526. With these added logs in the test, I think it should help in the failure investigations in any future failures in this test.
> 
> Repeat testing of this test in our CI, with this change, has passed. A tier2 testing is in progress.

test/jdk/java/net/Socket/CloseAvailable.java line 80:

> 78:             System.out.println(ss + " accepted connection " + acceptedSocket);
> 79:         } // (intentionally) close the ServerSocket
> 80: 

I wonder if we should join the thread here? Would that make the test more statble?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22511#discussion_r1867830652


More information about the net-dev mailing list