RFR: 8344229: Revisit SecurityManager usage in jdk.httpserver after JEP 486 integration [v2]

Volkan Yazıcı duke at openjdk.org
Tue Dec 3 21:15:56 UTC 2024


On Tue, 3 Dec 2024 20:03:25 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Volkan Yazıcı has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Finalize constants in `ServerConfig`
>
> src/jdk.httpserver/share/classes/sun/net/httpserver/ServerConfig.java line 80:
> 
>> 78:         idleIntervalMillis = Math.multiplyExact(
>> 79:                 providedIdleIntervalSecs > 0 ? providedIdleIntervalSecs : DEFAULT_IDLE_INTERVAL_IN_SECS,
>> 80:                 1000);
> 
> That's a change of behaviour - maybe we should keep the original behaviour that was not unreasonable: if the result of the computation overflows, use the implementation default value.

Fixed in 518f1eebe2ec0eb2a11f41853c301a61c16e1325.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22510#discussion_r1868372559


More information about the net-dev mailing list