RFR: 8345577: Additional clarification to the com.sun.net.httpserver.HttpExchange.getAttribute() and setAttribute() methods after JDK-8235786

Jaikiran Pai jpai at openjdk.org
Thu Dec 5 14:22:37 UTC 2024


On Thu, 5 Dec 2024 13:27:18 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Can I please get a review of this doc-only change which proposes to address https://bugs.openjdk.org/browse/JDK-8345577?
> 
> As noted in that issue, a recent update (in the current JDK mainline) to the javadoc of these methods made some existing external subclasses overridding these methods to contradict the specification of the methods. The update in this current PR relaxes the normative text and clarifies the JDK built-in implementation through a `@implSpec`.
> 
> No new tests have been added given the nature of this change. The CSR is ready for review https://bugs.openjdk.org/browse/JDK-8345582.

Hello Ethan,

> A doc only change does not address the issue, it merely tries to define it out of existence.

The intention of this PR and the previous update in https://bugs.openjdk.org/browse/JDK-8235786 isn't to change the current JDK built-in implementation. Instead it is to document the current behaviour.

The current implementation has been around for several releases. As a future and separate work, as noted in the CSR, alternatives will be considered to provide a way to set per exchange attributes.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22577#issuecomment-2520456681


More information about the net-dev mailing list