RFR: 8346017: Socket.connect specified to throw UHE for unresolved address is problematic for SOCKS V5 proxy [v3]

Volkan Yazıcı duke at openjdk.org
Fri Dec 13 14:56:56 UTC 2024


> [JDK-8343791](https://bugs.openjdk.org/browse/JDK-8343791) modified `Socket::connect` to throw `UHE` on unresolved addresses – merged in #22160. As reported in [JDK-8346017](https://bugs.openjdk.org/browse/JDK-8346017), this renders `connect()` unusable when there is a (SOCKS) proxy in play, where calling `connect()` using unresolved addresses is a valid operation. This PR
> 
> 1. Reverts the earlier `Socket::connect` change
> 2. Updates tests accordingly
> 3. Enhances tests with proxied socket inputs
> 
> These changes require CSR and RN tickets. I will implement them once we agree on a solution here.

Volkan Yazıcı has updated the pull request incrementally with two additional commits since the last revision:

 - Add `ConnectSocksProxyTest`
 - Add `NO_PROXY` case to `ConnectFailTest`

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/22719/files
  - new: https://git.openjdk.org/jdk/pull/22719/files/ca0bef40..694d284f

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=22719&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=22719&range=01-02

  Stats: 307 lines in 2 files changed: 216 ins; 62 del; 29 mod
  Patch: https://git.openjdk.org/jdk/pull/22719.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22719/head:pull/22719

PR: https://git.openjdk.org/jdk/pull/22719


More information about the net-dev mailing list