RFR: 8346378: Cannot use DllMain in libnet for static builds

Magnus Ihse Bursie ihse at openjdk.org
Tue Dec 17 14:27:53 UTC 2024


On Tue, 17 Dec 2024 14:07:00 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:

> Well, apparently `atexit` hooks are also [called from the DLL entry point](https://learn.microsoft.com/en-us/cpp/build/run-time-library-behavior?view=msvc-170), so your change shouldn't change the behavior too much.

Indeed. The difference is basically in a theoretical scenario where the dll is unloaded at some other time than when the process exits. This is not that is happening with our launcher, and I doubt it would be possible to achieve in practice, since it is not a tested setup.

> Most of the networking tests are under `TEST=jdk_net` (subset of tier2).

Thanks! I'll run those as well.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22788#issuecomment-2548600589


More information about the net-dev mailing list