Integrated: 8346378: Cannot use DllMain in libnet for static builds

[Magnus Ihse Bursie]

On Tue, 17 Dec 2024 10:51:52 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> To be able to properly support static builds on Windows in [JDK-8346377](https://bugs.openjdk.org/browse/JDK-8346377), we cannot use `DllMain`, for two reasons:
> 
> 1) This is not called for statically linked libraries, and
> 2) There are multiple `DllMain` definitions throughout the JDK native libraries, causing name collisions.
> 
> While it could have been possible to keep the `DllMain` function for non-static builds and just use an alternative solution for static builds, I think it is preferable to have a single solution that works as well for both static and dynamic builds.
> 
> On top of this, the existing solution was contrary to [Microsoft recommendations](https://learn.microsoft.com/en-us/windows/win32/api/winsock/nf-winsock-wsacleanup), which state: "The WSACleanup function typically leads to protocol-specific helper DLLs being unloaded. As a result, the WSACleanup function should not be called from the DllMain function in a application DLL. This can potentially cause deadlocks. "

This pull request has now been integrated.

Changeset: 8efc5585
Author:    Magnus Ihse Bursie <ihse at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/8efc5585b74714df6cf8e66853cb63d223534455
Stats:     38 lines in 4 files changed: 16 ins; 9 del; 13 mod

8346378: Cannot use DllMain in libnet for static builds

Reviewed-by: djelinski

-------------

PR: https://git.openjdk.org/jdk/pull/22788