RFR: 8336412: sun.net.www.MimeTable has a few unused methods [v2]
Volkan Yazıcı
duke at openjdk.org
Mon Dec 23 12:36:54 UTC 2024
On Thu, 19 Dec 2024 17:11:15 GMT, Roger Riggs <rriggs at openjdk.org> wrote:
>> Volkan Yazıcı has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Make `MimeTable` final
>
> src/java.base/share/classes/sun/net/www/MimeTable.java line 370:
>
>> 368: }
>> 369:
>> 370: public Properties getAsProperties() {
>
> Along with dropping the methods that might be used outside of the class including the saveAsProperties method, consider making the class final. (This is just part of the implementation so it really doesn't need that declaration)
> (I wonder if the Solaris implementation used the subclass or other paths).
Marked the class `final` in dbd8bab7f6c21993ad400edb322da79b91bee80a.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22831#discussion_r1895706800
More information about the net-dev
mailing list