RFR: 8319651: Several network tests ignore vm flags when start java process

Darragh Clarke dclarke at openjdk.org
Fri Feb 16 11:31:17 UTC 2024


On Fri, 9 Feb 2024 11:38:07 GMT, Darragh Clarke <dclarke at openjdk.org> wrote:

> Currently these tests ignore vm flags, In most cases I've updated them to use `ProcessTools.createTestJavaProcessBuilder` this usually required some cleanup also.
> 
> `test/jdk/java/net/ServerSocket/AcceptCauseFileDescriptorLeak.java` and `test/jdk/java/net/URLConnection/6212146/TestDriver.java` have been set to use `@require vm.flagless` because they both use `sh` commands.
> 
> I've ran these changes against tiers 1-3 and everything seems stable

Thanks for the suggestions and feedback, I think I've addressed everything now so will leave some time in case there is anything else and to rerun tests but will merge later.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17787#issuecomment-1948219622


More information about the net-dev mailing list