RFR: 8326233 Utils#copySSLParameters loses needClientAuth Setting

Jaikiran Pai jpai at openjdk.org
Tue Feb 20 06:29:01 UTC 2024


Can I please get a review for this change which proposes to fix https://bugs.openjdk.org/browse/JDK-8326233?

As noted in the issue, when the `java.net.HttpClient.Builder` is configured with a `SSLParameters` instance whose `needClientAuth` is set to true, then it is expected that the `HttpClient` that's built from such a build will have its `SSLParameters` with `needClientAuth` as `true` and `wantClientAuth` as `false`. But due to a bug in the internal implementation of a the `HttpClient`, the value for `needClientAuth` was getting reset to `false`. The commit in this PR fixes that issue and introduces a jtreg tests which reproduces the issue and verifies the fix.

-------------

Commit messages:
 - 8326233 Utils#copySSLParameters loses needClientAuth Setting

Changes: https://git.openjdk.org/jdk/pull/17923/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=17923&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8326233
  Stats: 39 lines in 2 files changed: 33 ins; 1 del; 5 mod
  Patch: https://git.openjdk.org/jdk/pull/17923.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17923/head:pull/17923

PR: https://git.openjdk.org/jdk/pull/17923


More information about the net-dev mailing list