RFR: 8326233 Utils#copySSLParameters loses needClientAuth Setting

[Daniel Jeliński]

On Tue, 20 Feb 2024 06:24:49 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Can I please get a review for this change which proposes to fix https://bugs.openjdk.org/browse/JDK-8326233?
> 
> As noted in the issue, when the `java.net.HttpClient.Builder` is configured with a `SSLParameters` instance whose `needClientAuth` is set to true, then it is expected that the `HttpClient` that's built from such a build will have its `SSLParameters` with `needClientAuth` as `true` and `wantClientAuth` as `false`. But due to a bug in the internal implementation of a the `HttpClient`, the value for `needClientAuth` was getting reset to `false`. The commit in this PR fixes that issue and introduces a jtreg tests which reproduces the issue and verifies the fix.

LGTM.

src/java.net.http/share/classes/jdk/internal/net/http/common/Utils.java line 620:

> 618: 
> 619:     public static SSLParameters copySSLParameters(SSLParameters p) {
> 620:         final SSLParameters p1 = new SSLParameters();

nit: I'm not a fan of labeling local variables as final; it doesn't add any value as far as I can tell. Can we keep it non-final?

-------------

Marked as reviewed by djelinski (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17923#pullrequestreview-1889887755
PR Review Comment: https://git.openjdk.org/jdk/pull/17923#discussion_r1495489302