RFR: 8326233 Utils#copySSLParameters loses needClientAuth Setting [v2]

Jaikiran Pai jpai at openjdk.org
Tue Feb 20 10:10:07 UTC 2024


> Can I please get a review for this change which proposes to fix https://bugs.openjdk.org/browse/JDK-8326233?
> 
> As noted in the issue, when the `java.net.HttpClient.Builder` is configured with a `SSLParameters` instance whose `needClientAuth` is set to true, then it is expected that the `HttpClient` that's built from such a build will have its `SSLParameters` with `needClientAuth` as `true` and `wantClientAuth` as `false`. But due to a bug in the internal implementation of a the `HttpClient`, the value for `needClientAuth` was getting reset to `false`. The commit in this PR fixes that issue and introduces a jtreg tests which reproduces the issue and verifies the fix.

Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:

  Daniel's review - remove "final"

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17923/files
  - new: https://git.openjdk.org/jdk/pull/17923/files/d8ec1d17..1b253398

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17923&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17923&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/17923.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17923/head:pull/17923

PR: https://git.openjdk.org/jdk/pull/17923


More information about the net-dev mailing list