RFR: 8326233 Utils#copySSLParameters loses needClientAuth Setting [v2]
Jaikiran Pai
jpai at openjdk.org
Tue Feb 20 12:51:15 UTC 2024
On Tue, 20 Feb 2024 11:13:04 GMT, John Jiang <jjiang at openjdk.org> wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Daniel's review - remove "final"
>
> test/jdk/java/net/httpclient/HttpClientBuilderTest.java line 283:
>
>> 281: }
>> 282: // needClientAuth = true and thus wantClientAuth = false
>> 283: final SSLParameters needClientAuthParams = new SSLParameters();
>
> You may also want to remove `final` at this line and line 293, though this is just be a test.
Done. I've updated the PR to remove the introduction of `final`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17923#discussion_r1495765012
More information about the net-dev
mailing list