Integrated: 8326233 Utils#copySSLParameters loses needClientAuth Setting

Jaikiran Pai jpai at openjdk.org
Wed Feb 21 01:28:59 UTC 2024


On Tue, 20 Feb 2024 06:24:49 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Can I please get a review for this change which proposes to fix https://bugs.openjdk.org/browse/JDK-8326233?
> 
> As noted in the issue, when the `java.net.HttpClient.Builder` is configured with a `SSLParameters` instance whose `needClientAuth` is set to true, then it is expected that the `HttpClient` that's built from such a build will have its `SSLParameters` with `needClientAuth` as `true` and `wantClientAuth` as `false`. But due to a bug in the internal implementation of a the `HttpClient`, the value for `needClientAuth` was getting reset to `false`. The commit in this PR fixes that issue and introduces a jtreg tests which reproduces the issue and verifies the fix.

This pull request has now been integrated.

Changeset: 36246c97
Author:    Jaikiran Pai <jpai at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/36246c975bd62845367fe67274d67bcffcff7c80
Stats:     38 lines in 2 files changed: 33 ins; 1 del; 4 mod

8326233: Utils#copySSLParameters loses needClientAuth Setting

Reviewed-by: djelinski, jjiang, dfuchs

-------------

PR: https://git.openjdk.org/jdk/pull/17923


More information about the net-dev mailing list