RFR: 8326381: com.sun.net.httpserver.HttpsParameters and SSLStreams incorrectly handle needClientAuth and wantClientAuth [v3]

[Jaikiran Pai]

On Wed, 21 Feb 2024 08:31:43 GMT, John Jiang <jjiang at openjdk.org> wrote:

>> Jaikiran Pai has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - introduce a test to verify the server honours needClientAuth and wantClientAuth when set through HttpsParameters
>>  - deprecate the SSL parameters related methods on HttpsParameter
>
> test/jdk/com/sun/net/httpserver/HttpsParametersClientAuthTest.java line 49:
> 
>> 47:      */
>> 48:     @Test
>> 49:     public void testClientAuth() throws Exception {
> 
> Just a suggestion.
> 
> Now that this test uses JUnit, why doesn't it define multiple test methods for the different HttpsParameters instances?
> A single test method just focus on only one HttpsParameters instance (or test case).
> 
> If the checking on a HttpsParameters instance (or test case) fails, the remaining test cases still can be executed.

Hello John, I've updated the PR to split these into separate test methods.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17940#discussion_r1499432033