RFR: 8326381: com.sun.net.httpserver.HttpsParameters and SSLStreams incorrectly handle needClientAuth and wantClientAuth [v3]

[John Jiang]

On Thu, 22 Feb 2024 15:32:03 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> test/jdk/com/sun/net/httpserver/HttpsParametersClientAuthTest.java line 72:
>> 
>>> 70:         assertFalse(wantClientAuthParams.getNeedClientAuth(),
>>> 71:                 "needClientAuth was expected to be false but wasn't");
>>> 72:     }
>> 
>> Is it necessary to check the states on the following cases?
>> 
>> 
>> HttpsParameters params = new Params();
>> params.setNeedClientAuth(true);
>> params.setWantClientAuth(false);
>> 
>> 
>> 
>> HttpsParameters params = new Params();
>> params.setWantClientAuth(true);
>> params.setNeedClientAuth(false);
>
> I don't have a preference, especially since we now decided to deprecate these methods. But if you prefer we add those, then let me know and I can update the test tomorrow.

I thought this fix made different states of `wantClientAuth` and `needClientAuth` for those cases.
So, it may be better to check if the states in those cases are expected, though they should be corner cases.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17940#discussion_r1499521538