RFR: 8326578: Clean up networking properties documentation [v2]
Daniel Fuchs
dfuchs at openjdk.org
Wed Feb 28 15:17:45 UTC 2024
On Wed, 28 Feb 2024 15:11:04 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:
>> Please review this patch that removes the specification of system properties that are no longer used:
>> - `http.auth.digest.cnonceRepeat` system property was removed in JDK 5
>> - `java.net.socks.username` and `java.net.socks.password` were never available as system properties; they were available as user preferences. The support for these preferences was removed in JDK 7.
>>
>> Additionally I updated the SOCKS proxy specification to match the user guide, and added the information that SOCKS proxies are only used by java.net TCP connections; the NIO SocketChannel does not support SOCKS proxies.
>
> Daniel Jeliński has updated the pull request incrementally with two additional commits since the last revision:
>
> - Reword the proxy descriptions
> - Add socksNonProxyHosts, mention ProxySelector
LGTM. Would be good to have @Michael-Mc-Mahon 's opinion too.
-------------
Marked as reviewed by dfuchs (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/17988#pullrequestreview-1906537283
More information about the net-dev
mailing list