RFR: 8333590: UnmodifiableHeaders.toString() returns a value that represents empty headers [v2]

[Daniel Fuchs]

On Wed, 5 Jun 2024 11:00:21 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Can I please get a review of this change which proposes to fix the issue noted in https://bugs.openjdk.org/browse/JDK-8333590?
>> 
>> As noted in that issue the `sun.net.httpserver.UnmodifiableHeaders`, an internal class, within the `jdk.httpserver` module doesn't override the `toString()` method. `UnmodifiableHeaders` is of type `com.sun.net.httpserver.Headers` which is a public API in the `jdk.httpserver` module.
>> 
>> When applications call `Headers.toString()`, if the instance is of type `UnmodifiableHeaders`, then the returned `String` representation shows empty headers, even when it isn't empty. The commit in this PR fixes the issue by implementing `toString()` in the `UnmodifiableHeaders` to return the correct representation of the headers.
>> 
>> An existing jtreg test has been updated to reproduce this issue and verify the fix.
>
> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update src/jdk.httpserver/share/classes/sun/net/httpserver/UnmodifiableHeaders.java
>   
>   Co-authored-by: Daniel Fuchs <67001856+dfuch at users.noreply.github.com>

LGTM

-------------

Marked as reviewed by dfuchs (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19555#pullrequestreview-2098856889