RFR: 8299487: Test java/net/httpclient/whitebox/SSLTubeTestDriver.java timed out

[Jaikiran Pai]

On Tue, 11 Jun 2024 17:07:38 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

> Here is a trivial change that might fix intermittent failures in the test java/net/httpclient/whitebox/SSLTubeTestDriver.java.
> The change makes sure the client connects using the loopback address instead of "localhost".
> 
> In case that does not fix the issue, some additional logging has been added to try to understand what's going on.

The changes look OK to me. I have added a couple of trivial review comments inline.

test/jdk/java/net/httpclient/whitebox/java.net.http/jdk/internal/net/http/SSLTubeTest.java line 149:

> 147:                 }
> 148:             } catch (Throwable e) {
> 149:                 System.out.println("clientReader got exception: " + e);

Hello Daniel, I think since we are printing the stacktrace on the next line, it might be better to use `System.err.println` here so that this message to ends up in the `System.err` section like the stacktrace. Same suggestion for 2 more places in this PR where we are introducing such messages in the Throwable block.

test/jdk/java/net/httpclient/whitebox/java.net.http/jdk/internal/net/http/SSLTubeTest.java line 219:

> 217:                         os.close();
> 218:                         serverSock.close();
> 219:                         System.out.println("serverLooback exiting normally");

Typo in the message, should have been `serverLoopback ...`. Same in 1 other place.

-------------

Marked as reviewed by jpai (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19663#pullrequestreview-2112118704
PR Review Comment: https://git.openjdk.org/jdk/pull/19663#discussion_r1635916191
PR Review Comment: https://git.openjdk.org/jdk/pull/19663#discussion_r1635916940