RFR: 8331195: Improve com.sun.net.httpserver.HttpExchange usability [v4]

Ethan McCue duke at openjdk.org
Sat Jun 15 03:25:19 UTC 2024


On Wed, 1 May 2024 21:12:05 GMT, robert engels <duke at openjdk.org> wrote:

>> improve the HttpExchange api with documented constants and convenience methods to avoid common bugs
>
> robert engels has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Merge remote-tracking branch 'robaho/HttpExchange-api-change' into HttpExchange-api-change
>    
>    # Conflicts:
>    #	src/jdk.httpserver/share/classes/com/sun/net/httpserver/HttpExchange.java
>  - update api changes based on comments

To reiterate, I'm still not the biggest fan of the constant names given

* The parameter name they are being used for is `responseLength`. "The responseLength is CHUNKED_CONTENT" feels jank and `lengthOrChunked` doesn't inspire joy.
* I'm not convinced the audience that we presumably care the most about for this API won't be helped too much by them

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18955#issuecomment-2169078030


More information about the net-dev mailing list