RFR: 8312444: Delete unused parameters and variables in SocketPermission [v2]
Korov
duke at openjdk.org
Sat Mar 2 13:51:04 UTC 2024
> Removing unused parameter `defval` in `SocketPermission.initEphemeralPorts`, so the variable `PRIV_PORT_MAX` and `DEF_EPH_LOW` unused too.
>
> Removing unused parameter `cname` in `SocketPermission.authorizedIPv4` and `SocketPermission.authorizedIPv6`.
>
> Parameter 'action' must be not empty so `a.length > 0`, the check `a.length - 1 < 0` can be removed.
Korov has updated the pull request incrementally with one additional commit since the last revision:
Modiy the code accordingto the review
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/18086/files
- new: https://git.openjdk.org/jdk/pull/18086/files/a07280d4..9ebd6e12
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=18086&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=18086&range=00-01
Stats: 11 lines in 1 file changed: 0 ins; 7 del; 4 mod
Patch: https://git.openjdk.org/jdk/pull/18086.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/18086/head:pull/18086
PR: https://git.openjdk.org/jdk/pull/18086
More information about the net-dev
mailing list