RFR: 8327738: Remove unused internal method sun.n.w.p.h.HttpURLConnection.setDefaultAuthenticator

Daniel Jeliński djelinski at openjdk.org
Mon Mar 11 09:21:55 UTC 2024


On Sun, 10 Mar 2024 20:12:10 GMT, Eirik Bjørsnøs <eirbjo at openjdk.org> wrote:

> Please review this cleanup PR which removes the internal, unused method `sun.n.w.p.h.HttpURLConnection.setDefaultAuthenticator` with associated code.
> 
> This was discovered while investigating methods annotated with `@Deprecated`, but missing `@deprecated` javadoc tags.
> 
> The method sets a private static field which is read in various places. This field and its uses is also removed. 
> 
> Testing: No tests changes in this PR, this is purely a cleanup removal of unused code. A grep for `setDefaultAuthentication` across the JDK repo after this PR returns no matches.

LGTM. Thanks!

-------------

Marked as reviewed by djelinski (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18178#pullrequestreview-1927310811


More information about the net-dev mailing list