RFR: 8327738: Remove unused internal method sun.n.w.p.h.HttpURLConnection.setDefaultAuthenticator [v2]

[Eirik Bjørsnøs]

On Mon, 11 Mar 2024 12:58:18 GMT, Eirik Bjørsnøs <eirbjo at openjdk.org> wrote:

>> Please review this cleanup PR which removes the internal, unused method `sun.n.w.p.h.HttpURLConnection.setDefaultAuthenticator` with associated code.
>> 
>> This was discovered while investigating methods annotated with `@Deprecated`, but missing `@deprecated` javadoc tags.
>> 
>> The method sets a private static field which is read in various places. This field and its uses is also removed. After these changes, the associated interface `HttpAuthenticator` falls out of use and is removed as well.
>> 
>> Testing: No tests changes in this PR, this is purely a cleanup removal of unused code. A grep for `setDefaultAuthentication` across the JDK repo after this PR returns no matches.
>
> Eirik Bjørsnøs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Delete deprecated interface HttpAuthenticator, which has now fallen out of use

Thanks to the Daniels for your reviews and testing help!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18178#issuecomment-1992206186