RFR: 8327989: java/net/httpclient/ManyRequest.java should not use "localhost" in URIs [v2]
Daniel Jeliński
djelinski at openjdk.org
Tue Mar 12 18:14:14 UTC 2024
On Tue, 12 Mar 2024 16:37:26 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:
>> Please find here a trivial test fix that removes usage of "localhost" from ManyRequest.java.
>> Use of "localhost" in test URIs is problematic as it leaves the test open to random failure when running on machines that have custom mappings for "localhost". The fix is to use the IP literal of the loopback address instead.
>
> Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision:
>
> Copyright update
test/jdk/java/net/httpclient/ManyRequests.java line 190:
> 188: URI baseURI = URIBuilder.newBuilder()
> 189: .scheme("https")
> 190: .host(InetAddress.getLoopbackAddress())
Suggestion:
.loopback()
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18239#discussion_r1521922362
More information about the net-dev
mailing list