RFR: 8327796: Add method to java.net.http.HttpRequest to return a GET request in one call [v5]
Daniel Fuchs
dfuchs at openjdk.org
Wed Mar 20 15:48:24 UTC 2024
On Wed, 20 Mar 2024 15:42:29 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:
>> Michael McMahon has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Update test/jdk/java/net/httpclient/GETTest.java
>>
>> Co-authored-by: Andrey Turbanov <turbanoff at gmail.com>
>
> src/java.net.http/share/classes/jdk/internal/net/http/HttpResponseImpl.java line 106:
>
>> 104: return Optional.of(body());
>> 105: } else {
>> 106: return Optional.empty();
>
> should close the body here if it is closeable - or subscribe and cancel the subscribtion if it is a publisher.
See https://git.openjdk.org/jdk/pull/18270
and https://bugs.openjdk.org/browse/JDK-8308364?focusedId=14583793&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14583793
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18227#discussion_r1532337601
More information about the net-dev
mailing list